fixing Unhandled Exception: type 'Null' is not a subtype of type 'Lis…#185
Closed
iaggocapitanio1 wants to merge 1 commit intoappwrite:mainfrom
Closed
fixing Unhandled Exception: type 'Null' is not a subtype of type 'Lis…#185iaggocapitanio1 wants to merge 1 commit intoappwrite:mainfrom
iaggocapitanio1 wants to merge 1 commit intoappwrite:mainfrom
Conversation
|
I think this can be closed because the Bug from #173 is fixed in the SDK generator now: appwrite/sdk-generator#751 |
Contributor
|
Unfortunately, this is a read-only repo as the code is generated by our SDK Generator, and changes made only here would be wiped in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves Issue #173 by implementing a fix in the serialization process of the
Userclass. Thelabelsfield, which previously could lead to a type cast error when null, has been adjusted to handle null values gracefully. This change ensures that whenlabelsis null, it defaults to an empty list, thereby avoiding the "type 'Null' is not a subtype of type 'List'" error.Test Plan
To verify these changes:
User.fromMapmethod correctly handles cases wherelabelsis null.Userobjects work as expected, even whenlabelsis null.Userclass to ensure compatibility with this change.Related PRs and Issues
This PR directly resolves Issue #173. No other related PRs at this time.
Additional Information
This change is a crucial step towards robust and error-resistant handling of optional fields in data models, enhancing the stability of the Appwrite codebase.
Have you read the Contributing Guidelines on issues?
Yes, I have read the contributing guidelines and ensured that my PR aligns with them.