Skip to content

Remove log rocket#994

Merged
eldadfux merged 2 commits intocloudfrom
chore-remove-logrocket
Mar 29, 2024
Merged

Remove log rocket#994
eldadfux merged 2 commits intocloudfrom
chore-remove-logrocket

Conversation

@ArmanNik
Copy link
Contributor

No description provided.

@ArmanNik ArmanNik self-assigned this Mar 29, 2024
@vercel
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 2:56pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 2:56pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 2:56pm

Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove some leftovers from code we used to hide input fields and other private information?

Should this also get merged to main or do we constantly have two branches for oss vs cloud?

Also, build fails.

@ArmanNik
Copy link
Contributor Author

ArmanNik commented Mar 29, 2024

  • Not sure it's worth the wor. It's just an extra data-private on some HTML tags and we might use it again if we implement another solution like sentry or posthog
  • Until cloud is on 1.5.x we are going to need two branches, we sync them regularly though
  • Should be fixed now 👍

@eldadfux eldadfux merged commit 32c742d into cloud Mar 29, 2024
@ArmanNik ArmanNik deleted the chore-remove-logrocket branch March 29, 2024 15:02
@stnguyen90 stnguyen90 changed the title chore: remove log rocket Remove log rocket Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants