Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
requested changes
Oct 11, 2022
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
1 inconsistency i found:
- navigate to Authentication > Users
- go to page 2
- click on Users tab heading
expected:
current page and URL matches
actual:
current page still indicates page 2, but the URL doesn't show page 2
ArmanNik
reviewed
Oct 12, 2022
Contributor
ArmanNik
left a comment
ArmanNik
left a comment
There was a problem hiding this comment.
Now it's possible to navigate to pages over the maximum limit (e.g. we can go to page 25 even if we have only 3 pages). Although it's a very niche case we might want to address it in some way :)
TorstenDittmann
changed the title
stnguyen90
approved these changes
Oct 12, 2022
ArmanNik
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Have you read the Contributing Guidelines on issues?
✅