Skip to content

fix flutter install command : pub get -> pub add#366

Merged
TorstenDittmann merged 1 commit intoappwrite:mainfrom
imtushardave:fix_5277_flutter_install_command_from_pub_get_to_pub_add
Apr 25, 2023
Merged

fix flutter install command : pub get -> pub add#366
TorstenDittmann merged 1 commit intoappwrite:mainfrom
imtushardave:fix_5277_flutter_install_command_from_pub_get_to_pub_add

Conversation

@imtushardave
Copy link
Contributor

What does this PR do?

Fix flutter installation command - pub get to pub add

Related PRs and Issues

(5277)

Have you read the Contributing Guidelines on issues?

@vercel
Copy link

vercel bot commented Mar 26, 2023

@imtushardave is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

const example1 = `dependencies:
appwrite: ^${$versions['client-flutter']}`;
const example2 = `pub get appwrite`;
const example2 = `pub add appwrite`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lohanidamodar,

Considering this is what the instructions are for the web SDK:

image

Should we just have the flutter installation instructions be:

You can install the SDK using the Dart package manager from your terminal:

flutter pub add appwrite

and get rid of the first section about the pubspec.yaml? For reference, the current instructions are:

image

@lohanidamodar
Copy link
Member

@stnguyen90 let's keep the first section and also use flutter pub add instead of pub add. Rest looks good.

@imtushardave imtushardave force-pushed the fix_5277_flutter_install_command_from_pub_get_to_pub_add branch from 4af9bc8 to f21646b Compare March 28, 2023 02:13
@stnguyen90
Copy link
Contributor

@imtushardave, thanks for updating the PR! 🙏🏼 In the future, please don't forget to re-request a review from the reviewers on the PR.

@imtushardave
Copy link
Contributor Author

@imtushardave, thanks for updating the PR! 🙏🏼 In the future, please don't forget to re-request a review from the reviewers on the PR.

Got it @stnguyen90. Will keep this in mind.

@TorstenDittmann TorstenDittmann merged commit 3dfa097 into appwrite:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants