Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@everly-gif does require only Yes @ArmanNik , That is all is required for this particular OAuth Provider. |
ArmanNik
approved these changes
Dec 9, 2022
Contributor
|
@chenparnasa are the icons ok? |
Author
|
what's the recommended size for the icons @ArmanNik @chenparnasa . I remember previously we preferred 100 x 100 , has that changed? |
Contributor
|
@everly-gif we use SVGs instead of PNGs for the new console, so size is not an issue since they are vector images 👍 |
christyjacob4
approved these changes
Dec 16, 2022
ArmanNik
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add frontend for line OAuth
Test Plan
Manual
Related PRs and Issues
appwrite/appwrite#4426
Have you read the Contributing Guidelines on issues?
Yes