Skip to content

Remove sequence on incoming docs #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 2 commits into from
Jul 29, 2025
Merged

Remove sequence on incoming docs #10228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf0a23
Remove sequence on incoming docs
abnegate Jul 29, 2025
933f07c
Add missing removal
abnegate Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/controllers/api/databases.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3453,6 +3453,7 @@ function updateAttribute(
} else {
$relation->removeAttribute('$collectionId');
$relation->removeAttribute('$databaseId');
$relation->removeAttribute('$sequence');
$relation->setAttribute('$collection', $relatedCollection->getId());
$type = Database::PERMISSION_UPDATE;
}
Expand Down Expand Up @@ -3485,6 +3486,9 @@ function updateAttribute(
}
}

// Remove sequence if set
unset($document['$sequence']);

// Assign a unique ID if needed, otherwise use the provided ID.
$document['$id'] = $sourceId === 'unique()' ? ID::unique() : $sourceId;
$document = new Document($document);
Expand Down Expand Up @@ -4074,6 +4078,9 @@ function updateAttribute(
$permissions = $document->getPermissions() ?? [];
}

// Remove sequence if set
unset($data['$sequence']);

$data['$id'] = $documentId;
$data['$permissions'] = $permissions;
$newDocument = new Document($data);
Expand Down Expand Up @@ -4708,6 +4715,9 @@ function updateAttribute(
}
}

// Remove sequence if set
unset($data['$sequence']);

$documents = [];

try {
Expand Down
Loading