Skip to content

fix: handled for the issue where partial export of custom libraries resulted in zero exported. #41416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomjose92 merged 2 commits into from
Nov 26, 2025
Merged

fix: handled for the issue where partial export of custom libraries resulted in zero exported. #41416

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c980b
Fixed issue where on adding custom libraries and trying to partial ex…
tomjose92 Nov 25, 2025
5f82e36
Added test case for partial export including widgets, datasources, qu…
tomjose92 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rc/main/java/com/appsmith/server/exports/internal/partial/PartialExportServiceCEImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ private Mono<ApplicationJson> exportFilteredCustomJSLib(
.getAllJSLibsInContext(branchedApplicationId, CreatorContextType.APPLICATION, false)
.flatMap(customJSLibs -> {
List<CustomJSLib> updatedCustomJSLibList = customJSLibs.stream()
.filter(customJSLib -> customJSLibSet.contains(customJSLib.getId()))
.filter(customJSLib -> customJSLibSet.contains(customJSLib.getId())
|| customJSLibSet.contains(customJSLib.getName()))
Copy link
Collaborator

@subrata71 subrata71 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this? The changes look good otherwise

Copy link
Contributor Author

@tomjose92 tomjose92 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test case for partial export as that was missing. This includes customjs lib export

.peek(CustomJSLib::sanitiseToExportDBObject)
.toList();
applicationJson.setCustomJSLibList(updatedCustomJSLibList);
Expand Down