Skip to content

fix: revert applications display correctly when AI agent flags are partially enabled#41318

Merged
jacquesikot merged 1 commit intoreleasefrom
revert-41317-fix/license_ai_agent_instance_enabled
Oct 27, 2025
Merged

fix: revert applications display correctly when AI agent flags are partially enabled#41318
jacquesikot merged 1 commit intoreleasefrom
revert-41317-fix/license_ai_agent_instance_enabled

Conversation

@jacquesikot
Copy link
Contributor

@jacquesikot jacquesikot commented Oct 27, 2025

Reverts #41317

Summary by CodeRabbit

  • Refactor
    • Updated application display conditions for different application types.

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/18837702804
Commit: 5a0df5d
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Mon, 27 Oct 2025 11:08:21 UTC

@jacquesikot jacquesikot requested a review from jsartisan October 27, 2025 09:58
@jacquesikot jacquesikot self-assigned this Oct 27, 2025
@jacquesikot jacquesikot changed the title Revert "fix: ensure applications display correctly when AI agent flags are partially enabled" fix: revert applications display correctly when AI agent flags are partially enabled Oct 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Walkthrough

Conditional logic for rendering application card lists is simplified in the Applications page. The non-Anvil ApplicationCardList now renders based solely on !isAiAgentInstanceEnabled, while the Anvil ApplicationCardList now renders based only on isAiAgentFlowEnabled, replacing previously compound conditions.

Changes

Cohort / File(s) Summary
Conditional Rendering Logic
app/client/src/ce/pages/Applications/index.tsx
Modified gating conditions for ApplicationCardList rendering: non-Anvil list now uses !isAiAgentInstanceEnabled instead of compound condition; Anvil list now uses isAiAgentFlowEnabled instead of compound condition

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify the simplified conditions align with intended feature flag behavior
  • Confirm no edge cases or feature interactions are affected by the removal of compound conditions

Poem

Flags untangled, logic refined,
Conditions simplified, cleaner design,
One path forward, the other behind,
Rendering rules now aligned! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title "fix: revert applications display correctly when AI agent flags are partially enabled" is partially related to the changeset but contains confusing phrasing. While it correctly identifies the subject matter (applications display and AI agent flags), the construction "fix: revert" is contradictory, and the phrasing "revert applications display correctly" is awkward and unclear. A reader scanning PR history might not immediately recognize this is reverting a previous PR rather than introducing a new fix, making it potentially misleading about the intent of the change.
Description Check ⚠️ Warning The pull request description is severely incomplete and does not follow the required template structure. While it references the issue being reverted (#41317) and includes passing Cypress test results, it entirely lacks the "Description" section header and content that should provide motivation, context, and any relevant links or dependencies. The "Communication" section with the DevRel/Marketing checkboxes is also missing. The description consists of only a single line of explanation followed by CI results, which falls well short of the template's requirements for a comprehensive pull request description. Add a proper "Description" section that explains why this revert is necessary, any relevant context or dependencies, and links to related documentation or discussions. Include the "Communication" section with the required checkboxes to indicate whether the DevRel and Marketing teams should be informed about this change. At minimum, clarify the rationale behind reverting #41317 beyond just the issue reference.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-41317-fix/license_ai_agent_instance_enabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Bug Something isn't working label Oct 27, 2025
@jacquesikot jacquesikot added the ok-to-test Required label for CI label Oct 27, 2025
@jacquesikot jacquesikot merged commit b345d08 into release Oct 27, 2025
52 checks passed
@jacquesikot jacquesikot deleted the revert-41317-fix/license_ai_agent_instance_enabled branch October 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants