Conversation
WalkthroughDependency version bumps: commons-validator updated from 1.7 to 1.10.0 in two Maven modules. No scope or other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
|
|
/build-deploy-preview skip-tests=false |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/17667774690. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/server/appsmith-interfaces/pom.xml (1)
127-131: Optional: enforce via Enforcer to prevent regressions.Add Maven Enforcer “banDuplicatePomDependencyVersions”/“requireUpperBoundDeps” or explicitly pin BeanUtils=1.11.0 in dependencyManagement to avoid an accidental downgrade.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/server/appsmith-interfaces/pom.xml(1 hunks)app/server/appsmith-server/pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: server-unit-tests / server-unit-tests
🔇 Additional comments (3)
app/server/appsmith-server/pom.xml (2)
186-189: Sanity: check validator behavior changes against URL/Email/Domain validation.1.10.0/1.9.x included fixes around TLD handling and URL/IBAN routines; low risk but could tighten validation. Please run existing validations in CI to catch regressions. (commons.apache.org)
186-189: Verify commons-beanutils is 1.11.0Good bump; should remediate CVE-2025-48734 (commons-validator 1.10.0 → commons-beanutils 1.11.0). Verification failed in the sandbox (mvn/rg unavailable) — run locally and confirm the transitive dependency:
mvn -q -pl app/server/appsmith-server -am dependency:tree -Dincludes=commons-beanutils:commons-beanutils # Ensure output contains: commons-beanutils:commons-beanutils:jar:1.11.0If any other dependency pulls an older commons-beanutils, enforce the patched version (add to app/server/appsmith-server/pom.xml or root dependencyManagement):
<dependencies> + <!-- Enforce patched BeanUtils for CVE-2025-48734 --> + <dependency> + <groupId>commons-beanutils</groupId> + <artifactId>commons-beanutils</artifactId> + <version>1.11.0</version> + </dependency>app/server/appsmith-interfaces/pom.xml (1)
127-131: Version alignment looks good — commons-validator 1.10.0 present; verify transitive commons-beanutilsapp/server/appsmith-interfaces/pom.xml contains commons-validator 1.10.0 (lines ~116–131); mvn wasn't available in the sandbox so I couldn't run dependency:tree to confirm transitive commons-beanutils versions.
Run locally: mvn -q -pl app/server/appsmith-interfaces -am dependency:tree -Dincludes=commons-beanutils:commons-beanutils — confirm no module brings commons-beanutils <1.11.0 (fix for CVE-2025-48734).
|
Deploy-Preview-URL: https://ce-41223.dp.appsmith.com |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes CVE-2025-48734
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/17723760561
Commit: d71d66e
Cypress dashboard.
Tags:
@tag.SanitySpec:
Mon, 15 Sep 2025 08:40:18 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit