Skip to content

feat: update premium icon for create datasource page #41109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesikot merged 2 commits into from
Jul 14, 2025
Merged

feat: update premium icon for create datasource page #41109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4535513
feat: implement new premium feature tag on datasources
jacquesikot Jul 14, 2025
da8a4ec
feat: enhance PremiumFeatureTag with accessibility support
jacquesikot Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/client/src/components/editorComponents/PremiumFeatureTag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import React from "react";
import { Icon, Tag } from "@appsmith/ads";

function PremiumFeatureTag() {
return (
<Tag isClosable={false} size="md">
<Icon name="star-line" size="sm" />
</Tag>
);
}

export default PremiumFeatureTag;
44 changes: 25 additions & 19 deletions app/client/src/pages/Editor/IntegrationEditor/DatasourceItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import {
DatasourceImage,
DatasourceName,
DatasourceNameWrapper,
DatasourceContentWrapper,
DatasourceLeftContent,
} from "./IntegrationStyledComponents";

interface DatasourceItem {
Expand Down Expand Up @@ -40,25 +42,29 @@ export default function DatasourceItem({
data-testid={dataCardTestId}
onClick={handleOnClick}
>
<DatasourceImage
alt={name}
className="content-icon"
data-testid={dataCardImageTestId}
src={icon}
/>
<DatasourceNameWrapper data-testid={dataCardWrapperTestId}>
<DatasourceName
className="t--plugin-name"
data-testid={dataNameTestId}
renderAs="p"
>
{name}
</DatasourceName>
<DatasourceDescription data-testid={dataCardDescriptionTestId}>
{description}
</DatasourceDescription>
</DatasourceNameWrapper>
{rightSibling}
<DatasourceContentWrapper>
<DatasourceLeftContent>
<DatasourceImage
alt={name}
className="content-icon"
data-testid={dataCardImageTestId}
src={icon}
/>
<DatasourceNameWrapper data-testid={dataCardWrapperTestId}>
<DatasourceName
className="t--plugin-name"
data-testid={dataNameTestId}
renderAs="p"
>
{name}
</DatasourceName>
<DatasourceDescription data-testid={dataCardDescriptionTestId}>
{description}
</DatasourceDescription>
</DatasourceNameWrapper>
</DatasourceLeftContent>
{rightSibling}
</DatasourceContentWrapper>
</DatasourceCard>
);
}
15 changes: 15 additions & 0 deletions app/client/src/pages/Editor/IntegrationEditor/IntegrationStyledComponents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,18 @@ export const DatasourceDescription = styled.div`
font-weight: var(--ads-v2-font-weight-normal);
line-height: var(--ads-v2-line-height-2);
`;

export const DatasourceContentWrapper = styled.div`
display: flex;
align-items: center;
justify-content: space-between;
width: 100%;
gap: var(--ads-v2-spaces-4);
`;

export const DatasourceLeftContent = styled.div`
display: flex;
align-items: center;
gap: var(--ads-v2-spaces-4);
flex: 1;
`;
23 changes: 3 additions & 20 deletions app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,17 @@
import React, { useState } from "react";
import { getAssetUrl } from "ee/utils/airgapHelpers";
import { Modal, ModalContent, Tag } from "@appsmith/ads";
import { Modal, ModalContent } from "@appsmith/ads";
import styled from "styled-components";
import ContactForm from "./ContactForm";
import { handlePremiumDatasourceClick } from "./Helpers";
import DatasourceItem from "../DatasourceItem";
import { createMessage } from "ee/constants/messages";
import { PREMIUM_DATASOURCES } from "ee/constants/messages";
import type { UpcomingIntegration } from "entities/Plugin";
import PremiumFeatureTag from "components/editorComponents/PremiumFeatureTag";

const ModalContentWrapper = styled(ModalContent)`
max-width: 518px;
`;

const PremiumTag = styled(Tag)`
color: var(--ads-v2-color-purple-700);
background-color: var(--ads-v2-color-purple-100);
border-color: var(--ads-v2-color-purple-300);
padding: var(--ads-v2-spaces-3) var(--ads-v2-spaces-2);
text-transform: uppercase;
> span {
font-weight: 700;
font-size: 10px;
}
`;

export default function PremiumDatasources(props: {
plugins: UpcomingIntegration[];
isIntegrationsEnabledForPaid?: boolean;
Expand Down Expand Up @@ -53,11 +40,7 @@ export default function PremiumDatasources(props: {
key={integration.name}
name={integration.name}
rightSibling={
!props.isIntegrationsEnabledForPaid && (
<PremiumTag isClosable={false} kind={"premium"}>
{createMessage(PREMIUM_DATASOURCES.PREMIUM_TAG)}
</PremiumTag>
)
!props.isIntegrationsEnabledForPaid && <PremiumFeatureTag />
}
/>
))}
Expand Down
Loading