-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: integrates on page unload behavior with backend for deployed mode of the app #41036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rahulbarwal
merged 29 commits into
release
from
rahulbarwal/issue40997/Task-Deployed-modeNavigation-Integration-Trigger-onPageUnloadActions-on-Navigation
Jul 2, 2025
Merged
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b15c7a7
feat: add page unload action execution support
rahulbarwal 8b9744e
feat: add selector for page unload actions
rahulbarwal cad5d05
refactor: simplify executePageUnloadActions by removing unused parameter
rahulbarwal 94bdbad
feat: add navigation action to support page transitions
rahulbarwal 7e52be7
refactor: update MenuItem component to use styled div and handle navi…
rahulbarwal 7ea82a5
feat: implement PluginActionSaga for executing plugin actions
rahulbarwal 5ef3f42
refactor: clean up PluginActionSaga by removing unused functions and …
rahulbarwal 3f9caea
feat: add support for page unload actions execution
rahulbarwal f5da5ea
refactor: simplify active page detection in MenuItem component
rahulbarwal eebd52b
test: add unit tests for MenuItem component
rahulbarwal 54597c8
test: add unit tests for NavigateActionSaga
rahulbarwal 943dd4a
test: add unit tests for executePageUnloadActionsSaga
rahulbarwal 9da78dc
refactor: remove MenuItem component and its associated tests
rahulbarwal 3f7204d
feat: implement NavigateActionSaga for page navigation
rahulbarwal c06bc97
refactor: move TriggerMeta interface to a separate types file
rahulbarwal 0925504
Updates imports
rahulbarwal 3e66087
refactor: update SourceEntity imports to new types file
rahulbarwal 233dbc5
chore: add circular dependencies documentation and refactor TriggerMe…
rahulbarwal fd4024f
refactor: enhance MoreDropdownButton component structure and navigati…
rahulbarwal b35abf1
refactor: enhance pushToHistory function and navigation handling in N…
rahulbarwal 277d324
fix: update XPath selector for active page retrieval in AppSettings
rahulbarwal 082f414
test: enhance NavigateActionSaga tests for improved navigation handling
rahulbarwal d3e4e43
test: enhance MenuItem tests with useNavigateToAnotherPage mock
rahulbarwal 69ec3cc
removes unnecessary files
rahulbarwal fce2595
Revert "chore: add circular dependencies documentation and refactor T…
rahulbarwal a95e07b
Revert "refactor: update SourceEntity imports to new types file"
rahulbarwal 2a68fbb
Revert "refactor: move TriggerMeta interface to a separate types file"
rahulbarwal 2192adb
feat: implement PluginActionSaga to handle plugin action execution
rahulbarwal f09e3c4
Merge pull request #41071 from appsmithorg/rahulbarwal/test1
rahulbarwal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import type { | ||
| TriggerKind, | ||
| TriggerSource, | ||
| } from "constants/AppsmithActionConstants/ActionConstants"; | ||
|
|
||
| export interface TriggerMeta { | ||
| source?: TriggerSource; | ||
| triggerPropertyName?: string; | ||
| triggerKind?: TriggerKind; | ||
| onPageLoad: boolean; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
app/client/src/components/editorComponents/Debugger/DebuggerEntityLink.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
app/client/src/components/editorComponents/Debugger/ErrorLogs/ErrorLogItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogHelper.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
app/client/src/components/editorComponents/Debugger/LogItem/LogItem.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/sagas/ActionExecution/types"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import type { ENTITY_TYPE } from "ee/entities/AppsmithConsole/utils"; | ||
| import type { PluginType } from "entities/Plugin"; | ||
| import type { HTTP_METHOD } from "PluginActionEditor/constants/CommonApiConstants"; | ||
|
|
||
| export interface SourceEntity { | ||
| type: ENTITY_TYPE; | ||
| // Widget or action name | ||
| name: string; | ||
| // Id of the widget or action | ||
| id: string; | ||
| // property path of the child | ||
| propertyPath?: string; | ||
| // plugin type of the action or type of widget | ||
| pluginType?: PluginType | string; | ||
| // http method of the api. (Only for api actions) | ||
| httpMethod?: HTTP_METHOD; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.