Skip to content

feat: improve recent domains section spacing and text truncation #40970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesikot merged 2 commits into from
Jun 19, 2025
Merged

feat: improve recent domains section spacing and text truncation #40970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69cd09c
refactor: Update SignUp component styles and improve domain display l…
jacquesikot Jun 18, 2025
5f976b0
refactor: Simplify margin logic for recent domains display in SignUp …
jacquesikot Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/client/src/pages/UserAuth/SignUp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const validate = (values: SignupFormValues) => {
};

const recentDomainsSection = recentDomains.length > 0 && (
<div className="mt-12">
<div className="mt-8">
<div className="mb-2">
<Text kind="body-m">{createMessage(YOU_VE_ALREADY_SIGNED_INTO)}</Text>
</div>
Expand All @@ -114,18 +114,20 @@ const recentDomainsSection = recentDomains.length > 0 && (

return (
<div
className="flex items-center justify-between p-1 mb-3"
className={`flex items-center justify-between p-1 ${
index === recentDomains.length - 1 ? "mb-0" : "mb-3"
Copy link
Copy Markdown
Contributor

@ankitakinger ankitakinger Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to a variable index === recentDomains.length - 1?

Copy link
Copy Markdown
Contributor Author

@jacquesikot jacquesikot Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}`}
key={domain}
>
<div className="flex items-center space-x-3">
<div className="w-8 h-8 bg-[color:var(--ads-color-background-secondary)] rounded-full flex items-center justify-center text-gray-600 font-light text-sm">
{avatarLetter}
</div>
<div className="flex flex-col">
<span className="text-md font-semibold text-gray-700">
<span className="text-md font-semibold text-gray-700 max-w-[180px] line-clamp-1">
{orgName}
</span>
<span className="text-xs font-light text-gray-500">
<span className="text-xs font-light text-gray-500 max-w-[180px] line-clamp-1">
{domain}
</span>
</div>
Expand Down
3 changes: 1 addition & 2 deletions app/client/src/utils/multiOrgDomains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ function isValidAppsmithDomain(domain: string): boolean {
domain.endsWith(".appsmith.com") &&
!domain.startsWith("login.") &&
!domain.startsWith("release.") &&
!domain.startsWith("dev.") &&
/^[a-z0-9-]+\.appsmith\.com$/i.test(domain)
!domain.startsWith("dev.")
);
}

Expand Down
Loading