Resolves #2236: Fixed jupyter notebook inline title #2306
Conversation
znation
left a comment
znation
left a comment
There was a problem hiding this comment.
One comment needs to be addressed; also, the Travis CI run is failing (not sure why).
| </style> \ | ||
| </head> \ | ||
| <body> \ | ||
| <h1> '+ title +' </h1> \ |
There was a problem hiding this comment.
title needs to be HTML encoded; otherwise some values of title could cause malformed HTML. You can use the HTML.escape in Python 3 and cgi.escape in Python 2 for this.
There was a problem hiding this comment.
Thanks @znation ! Will check and raise PR
znation
left a comment
znation
left a comment
There was a problem hiding this comment.
Just one comment, otherwise this is ready to go in. Thanks!
| from PIL import Image | ||
|
|
||
| import base64 | ||
| import cgi |
There was a problem hiding this comment.
Please put these imports within the if/else conditions where they are used. Otherwise one of the imports may fail on Python 2 or Python 3 (I think the html module is new in Python 3).
There was a problem hiding this comment.
@znation Thanks for your suggestion! Changes are implemented and request for PR
2 participants
This PR resolves #2236
Fixed Jupyter notebook inline title