[perf] Do stack allocs instead of heap allocs for small fixed-size allocations#3652
Open
MahdiBM wants to merge 2 commits into
Open
[perf] Do stack allocs instead of heap allocs for small fixed-size allocations#3652MahdiBM wants to merge 2 commits into
MahdiBM wants to merge 2 commits into
Conversation
Contributor
|
The allocation counts went down (success!) so we need to update the integration test thresholds to lock the win in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For small fixed-size allocations, we can use stack instead of heap.
Motivation:
Allocations are costly. Stack allocations are much cheaper than heap allocations.
Modifications:
Use
withUnsafeTemporaryAllocation(of:capacity:_:)instead of allocating anArray.withUnsafeTemporaryAllocationallocates on the stack for up to 1000 bytes.Result:
Better performance.