Skip to content

Conversation

@kukushechkin
Copy link
Contributor

@kukushechkin kukushechkin commented Nov 18, 2025

After the recent addition of macOS-based benchmarks, the main workflow has been failing with:

Error when evaluating 'strategy' for job 'benchmarks-macos'. apple/swift-nio/.github/workflows/benchmarks.yml@main (Line: 239, Col: 15): Matrix vector 'config' does not contain any values

This happens because swift-nio does not set any _enabled flag for any version of Xcode to run the benchmarks.

An example of a failed run: https://github.com/apple/swift-nio/actions/runs/19479529118

Motivation:

Scheduled jobs should not fail.

Modifications:

Added a condition for running macOS benchmarks matrix generation job.

Result:

Jobs should not fail without any Xcode versions picked for running benchmarks.

An example of a run with macos-matrix job skipped: https://github.com/apple/swift-nio/actions/runs/19482328681/job/55758816398
An example of a run with a opt-in macOS Benchmarks: https://github.com/apple/swift-nio/actions/runs/19484086327/job/55762298924

@kukushechkin kukushechkin added the semver/none No version bump required. label Nov 18, 2025
@kukushechkin kukushechkin marked this pull request as ready for review November 19, 2025 10:35
@kukushechkin kukushechkin requested a review from rnro November 19, 2025 10:35
@kukushechkin kukushechkin enabled auto-merge (squash) November 19, 2025 11:30
@kukushechkin kukushechkin merged commit 206dacf into apple:main Nov 19, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants