Fix naming in Wasm Swift SDK workflow #3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"SDK" and "Swift SDK" are different concepts, compare `swift build --help | grep sdk` output, where we have separate CLI options for these with different meaning: * SDK is used by Clang and Xcode, with Swift Driver also implementing the `-sdk` flag. There's no specification for how Clang SDKs are distributed, thus we don't distribute any Wasm SDK as such. * Swift SDK is purely a SwiftPM feature, which uses artifact bundles for distribution. We do distribute Swift SDKs for Wasm. Additionally, Wasm is not an acronym. Per the Wasm spec https://webassembly.github.io/spec/core/intro/introduction.html#wasm: > A contraction of “WebAssembly”, not an acronym, hence not using all-caps.
rnro
approved these changes
Oct 24, 2025
Contributor
rnro
left a comment
rnro
left a comment
There was a problem hiding this comment.
Looks good, thanks for clarifying!
Renaming the workflow like this could break downstream adopters but up until very recently this hardcoded NIOCore as a target so I don't think there are any right now so this should be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"SDK" and "Swift SDK" are different concepts, compare
swift build --help | grep sdkoutput, where we have separate CLI options for these with different meaning:-sdkflag. There's no specification for how Clang SDKs are distributed, thus we don't distribute any Wasm SDK as such.Same for static Linux BTW, so a separate PR is needed to clean up that confusion for Musl-related CI workflows.
Additionally, Wasm is not an acronym. Per the Wasm spec https://webassembly.github.io/spec/core/intro/introduction.html#wasm: