Work around Android nullability errors #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Android messed up their nullability annotations in fts_open. The original change in https://android.googlesource.com/platform/bionic/+/dec8efd72a6ad8b807a15a614ae1519487cfa456 asserted that fts_open's path argument took a non-null pointer to an array of non-null pointers to strings. That's challenging, because the _end_ of that array is indicated by a null pointer. Regardless, this was eventually fixed in https://android.googlesource.com/platform/bionic/+/da81ec4d1cbd0279014feb60535bf38defcd9346. Unfortunately, that was more than a year after the offending change, so we need to work around it. Modifications: Add a shim for Android that omits the nullability annotations. Use that shim on Android. Result: Android works again. Resolves apple#3273.
glbrntt
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Android messed up their nullability annotations in fts_open. The original change in https://android.googlesource.com/platform/bionic/+/dec8efd72a6ad8b807a15a614ae1519487cfa456 asserted that fts_open's path argument took a non-null pointer to an array of non-null pointers to strings. That's challenging, because the end of that array is indicated by a null pointer.
Regardless, this was eventually fixed in
https://android.googlesource.com/platform/bionic/+/da81ec4d1cbd0279014feb60535bf38defcd9346. Unfortunately, that was more than a year after the offending change, so we need to work around it.
Modifications:
Add a shim for Android that omits the nullability annotations. Use that shim on Android.
Result:
Android works again.
Resolves #3273.