Adding RawSpan support to writeBytes in ByteBuffer #3269
Conversation
Motivation: With the new Swift version (6.2) we get access to spans for safely interacting with the contiguous memory owned by other types. Allow users write bytes to the ByteBuffer with RawSpans. Modifications: * ByteBuffer-core: Overload the setBytes, _setBytes, and _setBytesAssumingUnique BufferAccess to use RawSpan instead of UnsafeRawBufferPointer * ByteBuffer-aux: Overload the writeBytes to use RawSpan instead of UnsafeRawBuf ferPointer Result: Users can now write the contiguous memory of other types into ByteBuffer using the new RawSpan overloads, removing the need for unsafe pointer handling.
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Shiny, this looks great. Thanks @yigityazicilar!
| @discardableResult | ||
| @inlinable | ||
| @available(macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26, *) | ||
| public mutating func writeBytes(_ bytes: RawSpan) -> Int { |
There was a problem hiding this comment.
Should we mark this as consuming?
There was a problem hiding this comment.
There's no need: we don't consume it. We copy the bytes out.
There was a problem hiding this comment.
Oh, and also Span is copyable, so consuming doesn't have much of a practical effect either. It can, in the best case, elide a copy of the Span object, but that's just two words so it's not really worth the hassle.
There was a problem hiding this comment.
Yeah Span is Copyable so this might give the compiler a nudge to optimize it a bit better. At least that's what I was thinking.
There was a problem hiding this comment.
If anything, it should be borrowing, right? We're happy to just borrow this -- now as per @Lukasa's point: not much to win here of course.
| @discardableResult | ||
| @inlinable | ||
| @available(macOS 26, iOS 26, tvOS 26, watchOS 26, visionOS 26, *) | ||
| public mutating func setBytes(_ bytes: RawSpan, at index: Int) -> Int { |
4 participants
Motivation:
With the new Swift version (6.2) we get access to spans for safely interacting with the contiguous memory owned by other types. Allow users write bytes to the ByteBuffer with RawSpans.
Modifications:
Result:
Users can now write the contiguous memory of other types into ByteBuffer using the new RawSpan overloads, removing the need for unsafe pointer handling.