Enable visionOS xcodebuilds by default in CI #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Building for visionOS no longer seems to be having issues on the runners, we should enable it to increase our test coverage. Modifications: Enable visionOS xcodebuilds by default in CI Result: NIO and downstream repositories will see their *existing* macOS CI workflows now build for visionOS.
gjcairo
approved these changes
May 8, 2025
glbrntt
pushed a commit
that referenced
this pull request
May 9, 2025
Reverts #3234 This seems to have caused some instability which I'll investigate so we should revert for now.
rnro
added a commit
that referenced
this pull request
May 13, 2025
### Motivation: Building for visionOS no longer seems to be having issues on the runners, we should enable it to increase our test coverage. ### Modifications: Enable visionOS xcodebuilds by default in CI ### Result: NIO and downstream repositories will see their *existing* macOS CI workflows now build for visionOS. They can be disabled if necessary by passing `visionos_xcode_build_enabled: false` See #3234, #3235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Building for visionOS no longer seems to be having issues on the runners, we should enable it to increase our test coverage.
###Modifications:
Enable visionOS xcodebuilds by default in CI
Result:
NIO and downstream repositories will see their existing macOS CI workflows now build for visionOS.
They can be disabled if necessary by passing
visionos_xcode_build_enabled: false