Clarify test server error code #3212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
semver/none
Motivation The NIOHTTP1TestServer had a weird codepath where we could hit errors configuring the channel pipeline, but we weren't sure why. I've investigated, and this happens because a Channel that had been accepted earlier was closed while we were waiting to start handling it. This is totally benign: the code works just fine in that situation. To be clear, though, let's document the behaviour and add a test. Modifications - Code comment to explain the behaviour - Added a regression test Result More confidence.
gjcairo
reviewed
Apr 16, 2025
gjcairo
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NIOHTTP1TestServer had a weird codepath where we could hit errors configuring the channel pipeline, but we weren't sure why. I've investigated, and this happens because a Channel that had been accepted earlier was closed while we were waiting to start handling it. This is totally benign: the code works just fine in that situation.
To be clear, though, let's document the behaviour and add a test.
Modifications
Result
More confidence.