Skip to content

Enable strict concurrency for NIOPosixTests #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glbrntt merged 2 commits into from
Apr 16, 2025
Merged

Enable strict concurrency for NIOPosixTests #3211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90182bf
Enable strict concurrency for NIOPosixTests
glbrntt Apr 15, 2025
99d09be
fixup reduce
glbrntt Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ let package = Package(
"CNIOLinux",
"CNIODarwin",
"NIOTLS",
]
],
swiftSettings: strictConcurrencySettings
),
.testTarget(
name: "NIOConcurrencyHelpersTests",
Expand Down
2 changes: 1 addition & 1 deletion Tests/NIOPosixTests/DatagramChannelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ class DatagramChannelTests: XCTestCase {
// Only run this test on platforms that support recvmmsg: the others won't even
// try.
#if os(Linux) || os(FreeBSD) || os(Android)
final class RecvMmsgHandler: ChannelInboundHandler {
final class RecvMmsgHandler: ChannelInboundHandler, Sendable {
typealias InboundIn = AddressedEnvelope<ByteBuffer>
typealias InboundOut = AddressedEnvelope<ByteBuffer>

Expand Down
6 changes: 3 additions & 3 deletions Tests/NIOPosixTests/EventLoopFutureTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ class EventLoopFutureTest: XCTestCase {
let promises: [EventLoopPromise<Int>] = (0..<100).map { (_: Int) in eventLoop.makePromise() }
let futures = promises.map { $0.futureResult }

let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop, +)
let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop) { $0 + $1 }
_ = promises.map { $0.fail(E()) }
XCTAssert(fN.eventLoop === eventLoop)
XCTAssertThrowsError(try fN.wait()) { error in
Expand All @@ -311,7 +311,7 @@ class EventLoopFutureTest: XCTestCase {

let futures = promises.map { $0.futureResult }

let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop, +)
let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop) { $0 + $1 }
XCTAssert(fN.eventLoop === eventLoop)
XCTAssertThrowsError(try fN.wait()) { error in
XCTAssertNotNil(error as? E)
Expand All @@ -327,7 +327,7 @@ class EventLoopFutureTest: XCTestCase {
promises.insert(failedPromise, at: promises.startIndex)

let futures = promises.map { $0.futureResult }
let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop, +)
let fN: EventLoopFuture<Int> = EventLoopFuture<Int>.reduce(0, futures, on: eventLoop) { $0 + $1 }

failedPromise.fail(E())

Expand Down
Loading