Add errorCaught to NIOTypedHTTPClientUpgradeHandler #3210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle errors fired by previous ChannelHandlers. Otherwise if they fail the error returned is `inappropriateOperationForState` which is not very informative.
adam-fowler
force-pushed
the
websocket-upgrade-errors
branch
from
68bbb20 to
a28c442
Compare
Lukasa
reviewed
Apr 16, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
One minor nit, otherwise this looks really good.
| } | ||
| } | ||
|
|
||
| public func errorCaught(context: ChannelHandlerContext, error: any Error) { |
Contributor
There was a problem hiding this comment.
We should probably fire the error on as well, to avoid breaking any systems that were relying on this.
Lukasa
approved these changes
Apr 16, 2025
Contributor
|
Looks like we have some test failures here. |
auto-merge was automatically disabled
April 16, 2025 13:27
Head branch was pushed to by a user without write access
Contributor
Author
Ah yeah forwarding the error means |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle errors fired by previous ChannelHandlers. eg NIOSSLClientHandler
Motivation:
Otherwise if a ChannelHandler previous to the upgrade ChannelHandler fails the error returned is
inappropriateOperationForStateand the error fired by the original ChannelHandler is lost.Added
testReturnsErrorsFromPriorChannelHandlers. Also had to reorganisesetUpClientChannelslightly so I could get the result of the upgrade.