Static SDK installation script improvements #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
install_static_sdk_resiliance
branch
2 times, most recently
from
7fe2c56 to
26f1815
Compare
rnro
changed the title
rnro
force-pushed
the
install_static_sdk_resiliance
branch
2 times, most recently
from
3ae85c9 to
1be75a4
Compare
gjcairo
requested changes
Apr 8, 2025
Motivation: Make static SDK installation scripts more modular and make failures easier to diagnose. Modifications: - Allow specification of binaries from outside the installation script - Remove script dependency installation from the script - Separate the Swift dependency installation into its own script - Fatal error explicitly if the installed Swift can't be found - Make curl operations for downloading artifacts explicitly fail Result: Scripts which are easier to maintain and operate.
This reverts commit 8f98c6d.
rnro
force-pushed
the
install_static_sdk_resiliance
branch
from
f0bb0ad to
cf7628c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static SDK installation script improvements
Motivation:
Make static SDK installation scripts more modular and make
failures easier to diagnose.
Modifications:
Result:
Scripts which are easier to maintain and operate.
An example CI run with this in operation https://github.com/apple/swift-nio/actions/runs/14329482180/job/40162003318?pr=3186