Strict concurrency for NIOPerformanceTester and NIOCrashTester #3167
Conversation
|
|
||
| final class NIOLockBenchmark: Benchmark { | ||
| final class NIOLockBenchmark: Benchmark, @unchecked Sendable { | ||
| // mutable state is protected by the lock |
There was a problem hiding this comment.
Nit but couldn't we wrap opsDone in a NIOLockedValueBox instead and remove the @unchecked?
There was a problem hiding this comment.
From a Sendable-cleanness perspective, yes. However, this is a benchmark for NIOLock, so using NIOLockedValueBox would somewhat defeat the point of the benchmark!
| return channel.pipeline.addHandler(self.serverHandler) | ||
| channel.eventLoop.makeCompletedFuture { | ||
| let serverHandler = ServerHandler(connectionEstablishedPromise, eventLoop: channel.eventLoop) | ||
| promise.succeed(NIOLoopBound(serverHandler, eventLoop: channel.eventLoop)) |
There was a problem hiding this comment.
Do we want this promise succeeded if adding the handler to the pipeline failed?
There was a problem hiding this comment.
If adding the handler fails then the bootstrap will throw anyway so it doesn't really matter.
|
|
||
| extension UDPBenchmark { | ||
| final class EchoHandler: ChannelInboundHandler { | ||
| final class EchoHandler: ChannelInboundHandler, Sendable { |
There was a problem hiding this comment.
Do we want this to be Sendable if we have a SendableView?
There was a problem hiding this comment.
The SendableView is on a different type.
3 participants
No description provided.