macOS CI pools #3163
Merged
macOS CI pools #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: With new runners coming online we are separating the runners into pools. * "nightly" runners are to be targeted for asynchronous work which users aren't waiting on such as overnight work. * "general" runners can be used for either synchronoous or asynchronous work. * At the moment all runers are "general" runners, a subset are "nightly" runners. The aim here is to prioritize work which users are waiting for such as on PRs. Asynchronous work prioritizing the "nightly" runners will likely end up queuing for the contended runners but synchronous work will claim any available node. Modifications: * Add a `runner_pool` input for the macOS workflow * Default the `runner_pool` to `nightly` since the vast majority of existing workflows are specifying asynchronous work. * Specify the runner pool in NIO's use of macOS CI. Result: Support for runner pools.
This reverts commit 18fe18a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for macOS CI runner pools
Motivation:
With new runners coming online we are separating the runners into pools.
aren't waiting on such as overnight work.
work.
runners.
The aim here is to prioritize work which users are waiting for such as
on PRs. Asynchronous work prioritizing the "nightly" runners will likely
end up queuing for the contended runners but synchronous work will claim
any available node.
Modifications:
runner_poolinput for the macOS workflowrunner_pooltonightlysince the vast majority ofexisting workflows are specifying asynchronous work.
Result:
Support for runner pools.
An example of this in action: https://github.com/apple/swift-nio/actions/runs/14188573697/job/39748250001