Separate build and test steps in macos_tests.yml
#3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate build and test steps in `macos_tests.yml`. Test execution can now also be disabled through an input. This is useful for clarity of output and also in some cases where test execution may not be supported yet.
glbrntt
reviewed
Mar 31, 2025
.github/workflows/macos_tests.yml
Outdated
| submodules: true | ||
| - name: Swift build | ||
| run: | | ||
| swift build --build-tests |
Contributor
There was a problem hiding this comment.
Should there be build argument overrides as well?
glbrntt
reviewed
Mar 31, 2025
| cat >> "$GITHUB_OUTPUT" << EOM | ||
| darwin-matrix=$( | ||
| xcode_15_4_enabled="${MATRIX_MACOS_15_4_ENABLED:=true}" | ||
| xcode_15_4_build_arguments_override="${MATRIX_MACOS_15_4_BUILD_ARGUMENTS_OVERRIDE:=""}" |
Contributor
There was a problem hiding this comment.
Do these need to be listed in the inputs?
Contributor
Author
There was a problem hiding this comment.
Good catch. I've not added it to 15.4 since that's deprecated. The bash defaulting should take care of this.
glbrntt
reviewed
Mar 31, 2025
| - name: Swift build | ||
| run: | | ||
| if [ -n "${{ matrix.config.build_arguments_override }}" ]; then | ||
| swift build "${{ matrix.config.build_arguments_override }}" |
Contributor
There was a problem hiding this comment.
Just checking that --build-tests is purposefully dropped here because the args are being overridden?
Contributor
Author
There was a problem hiding this comment.
Yeah I thought giving people power to totally customize was more general.
glbrntt
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate build and test steps in
macos_tests.yml. Test execution can now also be disabled through an input. This is useful for clarity of output and also in some cases where test execution may not be supported yet.