Use overflow addition in tests to avoid compilation failures #3155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A few tests are failing to compiler on 32-bit platforms with recently nightly toolchains. These tests are skipped if `Int` is 32 bits wide but the compiler doesn't know that. Modifications: - Use overflow addition to stop the compiler from complaining; the addition won't ever actually overflow because of the runtime check done ahead of time. Result: - Tests compile again - Resolves apple#3154
gjcairo
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A few tests are failing to compiler on 32-bit platforms with recently nightly toolchains. These tests are skipped if
Intis 32 bits wide but the compiler doesn't know that.Modifications:
Result: