Make static SDK curl for setup script #3142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
static_sdk_script
branch
25 times, most recently
from
8a3967e to
68898d6
Compare
rnro
force-pushed
the
static_sdk_script
branch
3 times, most recently
from
a2efc00 to
42e63f9
Compare
FranzBusch
approved these changes
Mar 13, 2025
.github/workflows/main.yml
Outdated
| name: Static SDK | ||
| # Workaround https://github.com/nektos/act/issues/1875 | ||
| uses: apple/swift-nio/.github/workflows/static_sdk.yml@main | ||
| uses: apple/swift-nio/.github/workflows/static_sdk.yml@static_sdk_script |
Member
There was a problem hiding this comment.
I assume once this is merged we will have a follow up changing this back?
Contributor
Author
There was a problem hiding this comment.
I think because this isn't a required change I can break just revert and break it now then merge it.
Motivation: The static SDK workflow currently assumes a local setup script which isn't true for external adopters. Modifications: The static SDK workflow now curls for the setup script. Result: External adopters should be unblocked.
This reverts commit 5783425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The static SDK workflow currently assumes a local setup script which isn't true for external adopters.
Modifications:
Result:
External adopters should be unblocked.