Enable strict concurrency checking for NIOTestUtils #3130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
strict_concurrency_niotestutils
branch
from
2b29729 to
dbbb75b
Compare
rnro
force-pushed
the
strict_concurrency_niotestutils
branch
3 times, most recently
from
61bd820 to
c0ff3e4
Compare
Motivation: To ensure `NIOTestUtils` concurrency safety. Modifications: * Enable strict concurrency checking in the package manifest. * `NIOHTTP1TestServer` does pipeline configuration as synchronous operations. Result: `NIOTestUtils` does not warn of concurrency issues, builds will warn and CI will fail if regressions are introduced.
rnro
force-pushed
the
strict_concurrency_niotestutils
branch
from
c0ff3e4 to
bdc82eb
Compare
Lukasa
reviewed
Mar 7, 2025
| try channel.pipeline.syncOperations.addHandler(TransformerHandler()) | ||
| _ = try channel.syncOptions!.setOption(.autoRead, value: true) | ||
| } catch { | ||
| assertionFailure("Channel initialization failed with: \(error)") |
Contributor
There was a problem hiding this comment.
Let's just fully fatalError here, no reason to be shy.
Lukasa
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To ensure
NIOTestUtilsconcurrency safety.Modifications:
NIOHTTP1TestServerdoes pipeline configuration as synchronous operations.Result:
NIOTestUtilsdoes not warn of concurrency issues, builds will warn and CI will fail if regressions are introduced.