Remove side effect from assertion in IPHeaderRemoverHandler #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The 'testRawSocketBootstrap_withProtocolNegotiation' test times out when run in release mode. This is because 'IPHeaderRemoverHandler' removes the IPv4 headers as a side effect of an assertion. This means that the headers are only removed when compiled in debug mode. Modifications: Always remove the headers. Result: The test passes in release mode.
Contributor
Author
|
Suspect CI will fail for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The 'testRawSocketBootstrap_withProtocolNegotiation' test times out when run in release mode. This is because 'IPHeaderRemoverHandler' removes the IPv4 headers as a side effect of an assertion. This means that the headers are only removed when compiled in debug mode.
Modifications:
Always remove the headers.
Result:
The test passes in release mode.