Add more methods to work with Isolated futures #3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Whilst working on the NIOHTTP1 strict concurrency work I encountered a few gaps in the API where I needed isolated analogues of methods on futures. Modifications: * Add `makeSucceededIsolatedFuture` * Add a new internal initializer for `EventLoopFuture` which does not require the value to be Sendable for use in isolated contexts. * Add a variant of `flatMapError` which can handle closures which return isolated futures * Add a `futureResult` computed property which allows us to avoid the otherwise clumsy `future.nonIsolated().futureResult.assumeIsolated()` Result: More ability to work with isolated futures.
Lukasa
reviewed
Feb 13, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Basically looking good, a few notes.
| } | ||
|
|
||
| @usableFromInline | ||
| var futureResult: EventLoopFuture<Value>.Isolated { |
Contributor
There was a problem hiding this comment.
As you've added this, we may as well make it public and inlinable.
weissi
reviewed
Feb 13, 2025
Co-authored-by: Johannes Weiss <[email protected]>
glbrntt
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Whilst working on the NIOHTTP1 strict concurrency work I encountered a few gaps in the API where I needed isolated analogues of methods on futures.
Modifications:
makeSucceededIsolatedFutureEventLoopFuturewhich does not require the value to be Sendable for use in isolated contexts.flatMapErrorwhich can handle closures which return isolated futuresfutureResultcomputed property which allows us to avoid the otherwise clumsyfuture.nonIsolated().futureResult.assumeIsolated()Result:
More ability to work with isolated futures.