Avoid using stderr explicitly #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation It's tempting for us to use the FILE * for stderr whenever we want to print to it. However, the Linux libc modules aren't appropriately annotated to call that field constant, and indeed it isn't. This causes Swift to throw a fit if we even touch it. Modifications Introduce an awkward function that issues direct writes to stderr instead of using the FILE *. Result Swift is happier.
gjcairo
approved these changes
Jan 24, 2025
rnro
approved these changes
Jan 24, 2025
comyar
reviewed
Jan 29, 2025
| var buf = buf | ||
| while buf.count > 0 { | ||
| // 2 is stderr | ||
| let rc = write(2, buf.baseAddress, buf.count) |
There was a problem hiding this comment.
I think you can use STDERR_FILENO instead of the hardcoded int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's tempting for us to use the FILE * for stderr whenever we want to print to it. However, the Linux libc modules aren't appropriately annotated to call that field constant, and indeed it isn't. This causes Swift to throw a fit if we even touch it.
Modifications
Introduce an awkward function that issues direct writes to stderr instead of using the FILE *.
Result
Swift is happier.