Add Sendable annotations to the syscall wrappers #3087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Unfortunately there are a few places where we have to help the compiler out to realise that our copies of the libc functions are also Sendable, and -require-explicit-sendable can cause us some trouble if we don't annotate our usableFromInline types. Modifications Annotate our usableFromInline types Add some @sendable Results The march continues
glbrntt
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unfortunately there are a few places where we have to help the compiler out to realise that our copies of the libc functions are also Sendable, and -require-explicit-sendable can cause us some trouble if we don't annotate our usableFromInline types.
Modifications
Annotate our usableFromInline types
Add some @sendable
Results
The march continues