Fix compiling on 6.1 #3057
Merged
Fix compiling on 6.1 #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jan 14, 2025
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import DequeModule | ||
| @preconcurrency import DequeModule |
Contributor
There was a problem hiding this comment.
Do we actually need a @preconcurrency import? Deque is Sendable if its Element is Sendable.
Contributor
Author
There was a problem hiding this comment.
Ah, because we support versions of swift-collections so old that they don't have that conformance. Let's lift the constraint.
Motivation: Swift 6.1 nightlies have added many new warnings and errors to NIO. This patch resolves all but one of them. Modifications: - Clean up missing imports - Move away from @_implementationOnly where necessary - Fix a few things where Sendable mismatches were present. Result: Clean compile again
Lukasa
force-pushed
the
cb-fix-61-compile
branch
from
6257e96 to
7e5ff76
Compare
glbrntt
approved these changes
Jan 14, 2025
Contributor
Author
|
I'll be merging over the API breakage checker, which is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 6.1 nightlies have added many new warnings and errors to NIO. This patch resolves all of them.
Modifications:
Result:
Clean compile again