GetaddrinfoResolver succeeds futures on eventLoop #3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `testClientBindWorksOnSocketsBoundToEitherIPv4OrIPv6Only` would fail sometimes leaking the IPv4 promise in `GetaddrinfoResolver` `HappyEyeballsConnector` returns the connection when it resolves either IPv4 of IPv6. It uses the `GetaddrinfoResolver` which holds a promise for each of the IPv4 and IPv6 resolution; when one is completed it is possible to start tearing down the test and shutting down the event loop before the other is completed and we leak the promise. Modifications: Complete both futures on the event loop rather than the dispatch queue. Result: The futures are completed in the same event loop tick meaning that we cannot continue execution and leak one.
glbrntt
requested changes
Jan 8, 2025
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
5.9 thresholds are off it seems.
glbrntt
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
testClientBindWorksOnSocketsBoundToEitherIPv4OrIPv6Onlywould fail sometimes leaking the IPv4 promise inGetaddrinfoResolverHappyEyeballsConnectorreturns the connection when it resolves either IPv4 of IPv6. It uses theGetaddrinfoResolverwhich holds a promise for each of the IPv4 and IPv6 resolution; when one is completed the connection will be returned and it is possible to start tearing down the test and shutting down the event loop before the other is completed and we leak the promise.Modifications:
Complete both futures on the event loop rather than the dispatch queue.
Result:
The futures are completed in the same event loop tick meaning that we cannot continue execution and leak one.