Fix flaky test testTasksScheduledDuringShutdownAreAutomaticallyCancel… #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ledOrNotScheduledAnymore # Motivation This task was flaky and hit the assertion with the count being 1 # Modification This changes the expectation to greater than 0 since we can always guarantee that one scheduled task is run but due to timing windows it might be that we shutdown the EL before the second task is enqueued which meant it was immediately failed. # Result One less flaky test
Lukasa
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ledOrNotScheduledAnymore
Motivation
This task was flaky and hit the assertion with the count being 1
Modification
This changes the expectation to greater than 0 since we can always guarantee that one scheduled task is run but due to timing windows it might be that we shutdown the EL before the second task is enqueued which meant it was immediately failed.
Result
One less flaky test