Skip to content

fix bogus "unleakable promise leaked" error message (#2855) #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 1 commit into from
Dec 16, 2024
Merged

fix bogus "unleakable promise leaked" error message (#2855) #3027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/NIOCore/EventLoopFuture.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ public struct EventLoopPromise<Value> {
internal static func makeUnleakablePromise(eventLoop: EventLoop, line: UInt = #line) -> EventLoopPromise<Value> {
EventLoopPromise<Value>(
eventLoop: eventLoop,
file: "BUG in SwiftNIO (please report), unleakable promise leaked.",
file: """
EventLoopGroup shut down with unfulfilled promises remaining. \
This suggests that the EventLoopGroup was shut down with unfinished work outstanding which is \
illegal. Either switch to using the singleton EventLoopGroups or fix the issue by only shutting down \
the EventLoopGroups when all the work associated with them has finished.
""",
line: line
)
}
Expand Down
Loading