Remove now unneeded fts_open bitcast for Android - #3025
Merged
Conversation
Lukasa
approved these changes
Dec 13, 2024
Lukasa
enabled auto-merge (squash)
December 13, 2024 08:16
Contributor
Author
|
Few CI failures are unrelated, as this only affects Android. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this changed function call for Android in #2660 earlier this year, because of an incorrect Bionic function signature as explained recently, but now that it has been worked around through a new API note as mentioned there, this change is no longer needed.
I simply did not notice this earlier because it still compiles and merely gives a warning, which removing this call now silences.