Skip to content

Avoid converting array holding existentials #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 4 commits into from
Nov 28, 2024
Merged

Avoid converting array holding existentials #3006

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acd2aa3
Avoid converting array holding existentials
Lukasa Nov 27, 2024
a656f44
Further tweaks to avoid reboxing
Lukasa Nov 28, 2024
55915fd
New allocation limits
Lukasa Nov 28, 2024
c54096c
Formatting
Lukasa Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/NIOCore/ChannelPipeline.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ extension ChannelPipeline {
/// - position: The position in the `ChannelPipeline` to add the handlers.
/// - Returns: A result representing whether the handlers were added or not.
fileprivate func addHandlersSync(
_ handlers: [ChannelHandler],
_ handlers: [ChannelHandler & Sendable],
position: ChannelPipeline.Position
) -> Result<Void, Error> {
switch position {
Expand All @@ -1140,7 +1140,7 @@ extension ChannelPipeline {
private func _addHandlersSync<Handlers: Sequence>(
_ handlers: Handlers,
position: ChannelPipeline.Position
) -> Result<Void, Error> where Handlers.Element == ChannelHandler {
) -> Result<Void, Error> where Handlers.Element == ChannelHandler & Sendable {
self.eventLoop.assertInEventLoop()

for handler in handlers {
Expand Down