Skip to content

Conversation

@weissi
Copy link
Member

@weissi weissi commented Nov 25, 2024

Motivation:

Warnings are annoying.

Modifications:

  • Remove unnecessary use of Foundation.Thread which isn't Sendable.
  • Remove now unnecessary @retroactives.
  • Enable -warnings-as-errors in CI

Result:

  • Warnings can't sneak in as easily anymore
  • No more warnings left in swift-nio
$ rm -rf .build/arm64-apple-macosx/ && swift build --build-tests -Xswiftc -warnings-as-errors > /dev/null
echo $?
$ echo $?
0

@weissi weissi requested a review from Lukasa November 25, 2024 18:04
@weissi weissi added the semver/none No version bump required. label Nov 25, 2024
@weissi weissi changed the title fix warnings around Foundation.Thread not being Sendable fix remaining warnings (in Xcode 16.2 beta) Nov 25, 2024
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you tweak the CI config to re-enable warnings as errors and lock this win in?

@weissi weissi changed the title fix remaining warnings (in Xcode 16.2 beta) fix remaining warnings & enable -warnings-as-errors in CI Nov 26, 2024
@weissi weissi requested a review from Lukasa November 26, 2024 09:30
@Lukasa Lukasa enabled auto-merge (squash) November 26, 2024 14:45
@Lukasa Lukasa merged commit 49b9d97 into apple:main Nov 26, 2024
42 of 43 checks passed
@weissi weissi deleted the jw-fwarns branch November 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants