Skip to content

Conversation

@weissi
Copy link
Member

@weissi weissi commented Nov 24, 2024

Motivation:

Warnings are annoying. Companion of #2994

Modifications:

Fix all the syncShutdownGracefully not being available in async contexts warnings.

Result:

Everybody happier.

@weissi weissi requested a review from Lukasa November 24, 2024 01:59
@weissi weissi added the semver/none No version bump required. label Nov 24, 2024
@weissi weissi requested review from FranzBusch and removed request for Lukasa November 24, 2024 02:01
throw XCTSkip("Custom executors are only supported in 5.9")
#else

let group = MultiThreadedEventLoopGroup(numberOfThreads: 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was actually a bug here which would always leak the group...

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✨

@Lukasa
Copy link
Contributor

Lukasa commented Nov 25, 2024

/__w/swift-nio/swift-nio/Tests/NIOPosixTests/SerialExecutorTests.swift:59:13: error: initialization of immutable value 'eventLoopGroup' was never used; consider replacing with assignment to '_' or removing it
        let eventLoopGroup = self.group
        ~~~~^~~~~~~~~~~~~~

@weissi
Copy link
Member Author

weissi commented Nov 25, 2024

/__w/swift-nio/swift-nio/Tests/NIOPosixTests/SerialExecutorTests.swift:59:13: error: initialization of immutable value 'eventLoopGroup' was never used; consider replacing with assignment to '_' or removing it
        let eventLoopGroup = self.group
        ~~~~^~~~~~~~~~~~~~

ta, fixed

@weissi weissi enabled auto-merge (squash) November 25, 2024 09:43
@weissi weissi merged commit dd7d4b0 into apple:main Nov 25, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants