-
Notifications
You must be signed in to change notification settings - Fork 721
Add ByteBuffer methods getUTF8ValidatedString and readUTF8ValidatedString #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c7e4353
Add ByteBuffer methods getValidatedString and readValidatedString
adam-fowler 1c15fd9
swift-format
adam-fowler 6ac9150
Swift 6 only
adam-fowler e4a4d1f
swift-format
adam-fowler 712ee77
Throw error when string is not valid UTF8
adam-fowler 88d6b80
Make ReadUTF8ValidationError Equatable
adam-fowler 926b53e
Use slice, add test for getUTF8ValidatedString
adam-fowler bea728b
Merge branch 'main' into read-validated-string
adam-fowler 242baca
Use readableBytesView
adam-fowler 75ba374
Swift format
adam-fowler aaa9d40
Merge branch 'main' into read-validated-string
adam-fowler f6f7576
Only compile UTF8 validated string tests i with Swift 6 or later
adam-fowler 4cf7b20
Move compiler test inside test functions and throw XCTSkip
adam-fowler 5cd6b53
Merge branch 'main' into read-validated-string
Lukasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.