Add WebSocketFrame.reservedBits OptionSet #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
changed the title
Lukasa
reviewed
Nov 15, 2024
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This mostly looks good, thanks Adam! A quick tweak on the diff.
| public struct ReservedBits: OptionSet, Sendable { | ||
| public var rawValue: UInt8 | ||
|
|
||
| public init(rawValue: UInt8) { |
Contributor
There was a problem hiding this comment.
Let's make this @inlinable and all the static vars as well. That unlocks the meaningful performance improvement.
Contributor
Author
There was a problem hiding this comment.
I just noticed the get/set accessors on firstByte are not @inlinable. Is it worthwhile tagging all of those? eg fin, opcode
Contributor
Author
There was a problem hiding this comment.
I tagged them anyway
adam-fowler
force-pushed
the
ws-reserved-bits
branch
from
84e97cf to
dfe0b3e
Compare
auto-merge was automatically disabled
November 15, 2024 17:26
Head branch was pushed to by a user without write access
Contributor
Author
|
aargh swift-format |
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 22, 2024
Add support for treating WebSocketFrame reserved bits as an option set ### Motivation: I would like to do mask operations on the reserved bits of the WebSocketFrame eg check none are set, check only bits in a mask are set. With the current public interface it is only possible to check the state of one bit at a time. ### Modifications: Add `WebSocketFrame.ReservedBits` OptionSet Add computed member `WebSocketFrame.reservedBits` ### Result: I can now check the status of multiple bits in one operation eg `frame.reservedBits.isEmpty` `frame.reservedBits.itersection([.rsv1, .rsv2]).isEmpty` (cherry picked from commit d836385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for treating WebSocketFrame reserved bits as an option set
Motivation:
I would like to do mask operations on the reserved bits of the WebSocketFrame eg check none are set, check only bits in a mask are set. With the current public interface it is only possible to check the state of one bit at a time.
Modifications:
Add
WebSocketFrame.ReservedBitsOptionSetAdd computed member
WebSocketFrame.reservedBitsResult:
I can now check the status of multiple bits in one operation eg
frame.reservedBits.isEmptyframe.reservedBits.itersection([.rsv1, .rsv2]).isEmpty