Remove sendable checking from NIOLock and NIOLockedValueBox #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ManagedBuffer is marked as explicitly not sendable on Swift nightly builds. NIOLock and NIOLockedValueBox used a type derived from ManagedBuffer and must be Sendable. Currently the derived type is marked as `@unchecked Sendable`. However on nightly toolchains this now conflicts with being explicitly not Sendable. Modifications: - Remove Sendable checking on NIOLock and NIOLockedValueBox Result: Fewer warnings
Lukasa
approved these changes
Nov 7, 2024
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 22, 2024
Motivation: ManagedBuffer is marked as explicitly not sendable on Swift nightly builds. NIOLock and NIOLockedValueBox used a type derived from ManagedBuffer and must be Sendable. Currently the derived type is marked as `@unchecked Sendable`. However on nightly toolchains this now conflicts with being explicitly not Sendable. Modifications: - Remove Sendable checking on NIOLock and NIOLockedValueBox Result: Fewer warnings (cherry picked from commit 6d30ec4)
glbrntt
added a commit
that referenced
this pull request
Nov 22, 2024
…#2968) (#2992) Motivation: ManagedBuffer is marked as explicitly not sendable on Swift nightly builds. NIOLock and NIOLockedValueBox used a type derived from ManagedBuffer and must be Sendable. Currently the derived type is marked as `@unchecked Sendable`. However on nightly toolchains this now conflicts with being explicitly not Sendable. Modifications: - Remove Sendable checking on NIOLock and NIOLockedValueBox Result: Fewer warnings (cherry picked from commit 6d30ec4) Co-authored-by: George Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ManagedBuffer is marked as explicitly not sendable on Swift nightly builds. NIOLock and NIOLockedValueBox used a type derived from ManagedBuffer and must be Sendable. Currently the derived type is marked as
@unchecked Sendable. However on nightly toolchains this now conflicts with being explicitly not Sendable.Modifications:
Result:
Fewer warnings