Skip to content

Improve docs around running act for formatting#2965

Merged
glbrntt merged 1 commit into
apple:mainfrom
glbrntt:fix-note-about-formatting
Nov 6, 2024
Merged

Improve docs around running act for formatting#2965
glbrntt merged 1 commit into
apple:mainfrom
glbrntt:fix-note-about-formatting

Conversation

@glbrntt

@glbrntt glbrntt commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

Motivation:

The contibuting guide gives an incorrect command to run to invoke the formatting job locally.

Modifications:

  • Change the job name to 'soundness'
  • Add a note about setting the container architecture

Result:

Better docs

Motivation:

The contibuting guide gives an incorrect command to run to invoke the
formatting job locally.

Modifications:

- Change the job name to 'soundness'
- Add a note about setting the container architecture

Result:

Better docs
@glbrntt glbrntt requested a review from rnro November 6, 2024 14:34
@glbrntt glbrntt added the semver/none No version bump required. label Nov 6, 2024
@glbrntt glbrntt enabled auto-merge (squash) November 6, 2024 14:34

@rnro rnro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@glbrntt glbrntt merged commit 2949000 into apple:main Nov 6, 2024
Lukasa pushed a commit to Lukasa/swift-nio that referenced this pull request Nov 21, 2024
Motivation:

The contibuting guide gives an incorrect command to run to invoke the
formatting job locally.

Modifications:

- Change the job name to 'soundness'
- Add a note about setting the container architecture

Result:

Better docs

(cherry picked from commit 2949000)
Lukasa added a commit that referenced this pull request Nov 21, 2024
Motivation:

The contibuting guide gives an incorrect command to run to invoke the
formatting job locally.

Modifications:

- Change the job name to 'soundness'
- Add a note about setting the container architecture

Result:

Better docs

(cherry picked from commit 2949000)

Co-authored-by: George Barnett <gbarnett@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants