Correct allocation test script #2956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Unfortunately the current script has a bug meaning it can never fail. Modifications: Change bracketing for output search. Result: Allocation tests will flag when failing
Lukasa
approved these changes
Oct 30, 2024
ali-ahsan-ali
approved these changes
Oct 31, 2024
FranzBusch
approved these changes
Oct 31, 2024
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 21, 2024
Motivation: Unfortunately the current script has a bug meaning it can never fail. Modifications: Change bracketing for output search. Result: Allocation tests will flag when failing (cherry picked from commit e1d0d21)
Lukasa
added a commit
that referenced
this pull request
Nov 21, 2024
Motivation: Unfortunately the current script has a bug meaning it can never fail. Modifications: Change bracketing for output search. Result: Allocation tests will flag when failing (cherry picked from commit e1d0d21) Co-authored-by: Peter Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unfortunately the current script has a bug meaning it can never fail.
Modifications:
Change bracketing for output search.
Result:
Allocation tests will flag when failing