Skip to content

[CI] Fix the Windows 6.0 check name #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranzBusch merged 1 commit into from
Oct 23, 2024
Merged

[CI] Fix the Windows 6.0 check name #2941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/swift_matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash

windows:
name: Windows (6.0)
name: Windows (${{ matrix.swift.swift_version }})
runs-on: windows-2022
strategy:
fail-fast: false
Expand All @@ -159,7 +159,6 @@ jobs:
- image: swift:6.0-windowsservercore-ltsc2022
swift_version: "6.0"
enabled: ${{ inputs.matrix_windows_6_0_enabled }}
if: ${{ inputs.matrix_windows_6_0_enabled }}
Copy link
Copy Markdown
Member Author

@FranzBusch FranzBusch Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These if checks caused the naming problems since those are evaluated before the matrix so if we disabled the check then the names would get bad

steps:
- name: Pull Docker image
if: ${{ matrix.swift.enabled }}
Expand Down Expand Up @@ -191,7 +190,6 @@ jobs:
- image: swiftlang/swift:nightly-main-windowsservercore-1809
swift_version: "nightly-main"
enabled: ${{ inputs.matrix_windows_nightly_main_enabled }}
if: (${{ inputs.matrix_windows_nightly_6_0_enabled }} || ${{ inputs.matrix_windows_nightly_main_enabled }})
steps:
- name: Pull Docker image
if: ${{ matrix.swift.enabled }}
Expand Down