Add convenience conformances to ByteCount#2909
Merged
glbrntt merged 3 commits intoOct 9, 2024
Merged
Conversation
Motivation: Several arithmetic and comparison operations are done with `ByteCount` using the `bytes` property. Operating on the `ByteCount` type directly will be more convenient. Modifications: - Add `AdditiveArithmetic` and `Comparable` conformances to `ByteCount`. Result: The `ByteCount` type can undergo arithmetic and comparison operations.
glbrntt
requested changes
Oct 9, 2024
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks good, just need to fix up one thing first
Co-authored-by: George Barnett <[email protected]>
glbrntt
reviewed
Oct 9, 2024
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks good but the format checking CI failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Several arithmetic and comparison operations are done with
ByteCountusing thebytesproperty. Operating on theByteCounttype directly will be more convenient.Modifications:
AdditiveArithmeticandComparableconformances toByteCount.Result:
The
ByteCounttype can undergo arithmetic and comparison operations.