A DatagramChannelTest now waits for writes#2905
Merged
Merged
Conversation
rnro
force-pushed
the
DatagramChannelTests_race
branch
from
7a489d0 to
8f27db4
Compare
glbrntt
approved these changes
Oct 4, 2024
Motivation: In `DatagramChannelTests.testChannelCanReportWritableBufferedBytesWithDataLargerThanSendBuffer` we assert that there are no buffered writable bytes immediately after a flush, however in some cases tests fail as this is not true. We suspect that this is because in some situations the kernel can be slow to drain the write buffer leading to racey behavior. Modifications: Wait for writes to complete before asserting that the buffer is emptied. Result: Tests should be more deterministic. Co-authored-by: Cory Benfield <[email protected]>
rnro
force-pushed
the
DatagramChannelTests_race
branch
from
8f27db4 to
a2f277a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In
DatagramChannelTests.testChannelCanReportWritableBufferedBytesWithDataLargerThanSendBufferwe assert that there are no buffered writable bytes immediately after a flush, however in some cases tests fail as this is not true.We suspect that this is because in some situations the kernel can be slow to drain the write buffer leading to racey behavior.
Modifications:
Wait for writes to complete before asserting that the buffer is emptied.
Result:
Tests should be more deterministic.