Skip to content

Comments

Link to more appropriate (still open) Swift issue#50

Merged
weissi merged 2 commits intomasterfrom
wip-update-issue-link-1
Apr 15, 2019
Merged

Link to more appropriate (still open) Swift issue#50
weissi merged 2 commits intomasterfrom
wip-update-issue-link-1

Conversation

@ktoso
Copy link
Member

@ktoso ktoso commented Apr 15, 2019

The original issue that was https://bugs.swift.org/browse/SR-9687 has been closed as duplicate of https://bugs.swift.org/browse/SR-9686
Perhaps it would be less confusing for others reading the code if we linked to the not-closed issue?

Not a big deal, just something I noticed; if we want to continue to link to the original issue that's fine too.

The original issue that was https://bugs.swift.org/browse/SR-9687 has been closed as duplicate of https://bugs.swift.org/browse/SR-9686
Perhaps it would be less confusing for others reading the code if we linked to the not-closed issue?

Not a big deal, just something I noticed; if we want to continue to link to the original issue that's fine too.
@ktoso ktoso requested a review from weissi April 15, 2019 01:35
Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@weissi weissi merged commit 856a83e into master Apr 15, 2019
@weissi weissi deleted the wip-update-issue-link-1 branch April 15, 2019 10:59
@weissi weissi added the 🔨 semver/patch No public API change. label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants